lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] infiniband: remove unnecessary fallthrough usage
On 2020-08-31 18:34, Jason Gunthorpe wrote:
> On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
>> Since /* fallthrough */ comments are deprecated[1], they are being
>> replaced
>> by new 'fallthrough' pseudo-keyword.
>>
>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>> highlight=fallthrough#implicit-switch-case-fall-through
>>
>> This sometimes leads to unreachable code warnings by static analyzers,
>> particularly in this case, Coverity Scanner. (CID 1466512)
>>
>> Remove unnecessary 'fallthrough' keywords to prevent dead code
>> warnings.
>>
>> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
>> ---
>> drivers/infiniband/hw/qib/qib_mad.c | 2 --
>> 1 file changed, 2 deletions(-)
>
> Alex beat you to it:
>
> https://patchwork.kernel.org/patch/11736039/

Well, I'm glad it's fixed :)

Thanks for sharing

>
> Thanks,
> Jason

--
Cengiz Can
@cengiz_io

\
 
 \ /
  Last update: 2020-08-31 18:01    [W:0.253 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site