lkml.org 
[lkml]   [2020]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function
Date
Christian Lamparter <chunkeey@gmail.com> writes:

> On Thursday, 27 August 2020 11:33:51 CEST Lee Jones wrote:
>> 'ar9170_qmap' is used in some source files which include carl9170.h,
>> but not all of them. A 'defined but not used' warning is thrown when
>> compiling the ones which do not use it.
>>
>> Fixes the following W=1 kernel build warning(s)
>>
>> from drivers/net/wireless/ath/carl9170/carl9170.h:57,
>> In file included from drivers/net/wireless/ath/carl9170/carl9170.h:57,
>> drivers/net/wireless/ath/carl9170/carl9170.h:71:17: warning:
>> ‘ar9170_qmap’ defined but not used [-Wunused-const-variable=]
>>
>> NB: Snipped - lots of these repeat
>>
>> Cc: Christian Lamparter <chunkeey@googlemail.com>
>> Cc: Kalle Valo <kvalo@codeaurora.org>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Cc: Johannes Berg <johannes@sipsolutions.net>
>> Cc: linux-wireless@vger.kernel.org
>> Cc: netdev@vger.kernel.org
>> Suggested-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> Signed-off-by: Lee Jones <lee.jones@linaro.org>
>> ---
>
> For what it's worth:
> Acked-by: Christian Lamparter <chunkeey@gmail.com>

BTW for me Acked-by tags from the maintainer are very useful. Patchwork
even collects them automatically and shows the statistics so I can
quickly see what patches are ready to be applied. So please do send them
if you can :)

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2020-08-31 15:57    [W:0.122 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site