Messages in this thread | | | Subject | Re: [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and supplies to required properties | From | Sowjanya Komatineni <> | Date | Mon, 31 Aug 2020 13:37:21 -0700 |
| |
On 8/31/20 1:17 PM, Sakari Ailus wrote: > Hi Sowjanya, > > On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote: >> Clock and supplies are external to IMX274 sensor and are dependent >> on camera module design. >> >> So, this patch moves them to required properties. >> >> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com> >> --- >> Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt >> index d0a5c899..b43bed6 100644 >> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt >> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt >> @@ -10,15 +10,15 @@ at 1440 Mbps. >> Required Properties: >> - compatible: value should be "sony,imx274" for imx274 sensor >> - reg: I2C bus address of the device >> - >> -Optional Properties: >> -- reset-gpios: Sensor reset GPIO >> - clocks: Reference to the input clock. >> - clock-names: Should be "inck". >> - vana-supply: Sensor 2.8v analog supply. >> - vdig-supply: Sensor 1.8v digital core supply. >> - vddl-supply: Sensor digital IO 1.2v supply. > If these have been optional in the past I don't think we can start > requiring them now. > > The framework will just give the driver a dummy regulator if one isn't > found. These were added recently with my patches. So I hope should be ok to make them required as they are external to sensor > >> >> +Optional Properties: >> +- reset-gpios: Sensor reset GPIO >> + >> The imx274 device node should contain one 'port' child node with >> an 'endpoint' subnode. For further reading on port node refer to >> Documentation/devicetree/bindings/media/video-interfaces.txt.
| |