Messages in this thread | | | Date | Sun, 30 Aug 2020 14:13:52 +0530 | From | Vaibhav Gupta <> | Subject | Re: [PATCH v1] [media] netup_unidvb: use generic power management |
| |
On Sun, Aug 30, 2020 at 09:10:04AM +0100, Sean Young wrote: > On Tue, Jul 28, 2020 at 02:57:17PM +0530, Vaibhav Gupta wrote: > > The .suspend() and .resume() callbacks are not defined for this driver. > > Still, their power management structure follows the legacy framework. To > > bring it under the generic framework, simply remove the binding of > > callbacks from "struct pci_driver". > > Unlisted fields in a static struct initializer will get set to 0 (or NULL > for pointers) already. Removing the NULL initializers will not change > anything. > > Possibly you want to remove the redundant initializers but your commit > message should say so. > > > Sean > Hello Sean,
Yes, you are right. I mentioned a general commit message. I will send a v2 with suggested changes.
Thank you Vaibhav Gupta
| |