Messages in this thread | | | From | Sven Schnelle <> | Subject | Re: [PATCH 1/2] vdso: allow to add architecture-specific vdso data | Date | Mon, 03 Aug 2020 16:01:18 +0200 |
| |
Thomas Gleixner <tglx@linutronix.de> writes:
> just a few nits. > > Can you please spare that #ifdef and do: > > #ifdef CONFIG_ARCH_HAS_VDSO_DATA > #include <asm/vdso/data.h> > #else > struct arch_vdso_data {}; > #endif
Ok.
> Please keep the tabular alignment of the struct members and add kernel > doc in the comment above the struct.
Ok.
> Aside of that 'arch' is not really a intuitive name. 'arch_data' or > something like that. Hmm?
arch_data is fine, thank you for your comments.
Regards Sven
| |