lkml.org 
[lkml]   [2020]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 28/51] selftests/net: rxtimestamp: fix clang issues for target arch PowerPC
    Date
    From: Tanner Love <tannerlove@google.com>

    [ Upstream commit 955cbe91bcf782c09afe369c95a20f0a4b6dcc3c ]

    The signedness of char is implementation-dependent. Some systems
    (including PowerPC and ARM) use unsigned char. Clang 9 threw:
    warning: result of comparison of constant -1 with expression of type \
    'char' is always true [-Wtautological-constant-out-of-range-compare]
    &arg_index)) != -1) {

    Tested: make -C tools/testing/selftests TARGETS="net" run_tests

    Fixes: 16e781224198 ("selftests/net: Add a test to validate behavior of rx timestamps")
    Signed-off-by: Tanner Love <tannerlove@google.com>
    Acked-by: Willem de Bruijn <willemb@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/networking/timestamping/rxtimestamp.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/tools/testing/selftests/networking/timestamping/rxtimestamp.c b/tools/testing/selftests/networking/timestamping/rxtimestamp.c
    index 7a573fb4c1c4e..c6428f1ac22fb 100644
    --- a/tools/testing/selftests/networking/timestamping/rxtimestamp.c
    +++ b/tools/testing/selftests/networking/timestamping/rxtimestamp.c
    @@ -328,8 +328,7 @@ int main(int argc, char **argv)
    bool all_tests = true;
    int arg_index = 0;
    int failures = 0;
    - int s, t;
    - char opt;
    + int s, t, opt;

    while ((opt = getopt_long(argc, argv, "", long_options,
    &arg_index)) != -1) {
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-03 14:39    [W:5.444 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site