lkml.org 
[lkml]   [2020]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 020/120] virtio_balloon: fix up endian-ness for free cmd id
    Date
    From: Michael S. Tsirkin <mst@redhat.com>

    commit 168c358af2f8c5a37f8b5f877ba2cc93995606ee upstream.

    free cmd id is read using virtio endian, spec says all fields
    in balloon are LE. Fix it up.

    Fixes: 86a559787e6f ("virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT")
    Cc: stable@vger.kernel.org
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    Acked-by: Jason Wang <jasowang@redhat.com>
    Reviewed-by: Wei Wang <wei.w.wang@intel.com>
    Acked-by: David Hildenbrand <david@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/virtio/virtio_balloon.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/virtio/virtio_balloon.c
    +++ b/drivers/virtio/virtio_balloon.c
    @@ -578,10 +578,14 @@ static int init_vqs(struct virtio_balloo
    static u32 virtio_balloon_cmd_id_received(struct virtio_balloon *vb)
    {
    if (test_and_clear_bit(VIRTIO_BALLOON_CONFIG_READ_CMD_ID,
    - &vb->config_read_bitmap))
    + &vb->config_read_bitmap)) {
    virtio_cread(vb->vdev, struct virtio_balloon_config,
    free_page_hint_cmd_id,
    &vb->cmd_id_received_cache);
    + /* Legacy balloon config space is LE, unlike all other devices. */
    + if (!virtio_has_feature(vb->vdev, VIRTIO_F_VERSION_1))
    + vb->cmd_id_received_cache = le32_to_cpu((__force __le32)vb->cmd_id_received_cache);
    + }

    return vb->cmd_id_received_cache;
    }

    \
     
     \ /
      Last update: 2020-08-03 14:23    [W:6.900 / U:0.256 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site