lkml.org 
[lkml]   [2020]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] ia64: clean-up header dependency and build process, fix build warning
Date

Randy Dunlap reports the following warning with CONFIG_IA64_PALINFO=m:

../scripts/Makefile.build:68: 'arch/ia64/kernel/palinfo.ko' will not be built even though obj-m is specified.
../scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead.

This comes from the fact Kbuild descends into arch/ia64/kernel/ twice.

First, to generate <generated/nr-irqs.h>,
Second, to build kernel and module objects.

The warning is emitted in the first descend because it is not the
intended usage.

I looked into the code closely, and noticed arch/ia64/kernel/nr-irqs.c
was not needed in the first place.

It was separated out of arch/ia64/kernel/asm-offsets.c just because
<asm/mca.h> was including too many bogus headers.

IA64 is not actively maintained, and there exists unneeded obsolete code.

The first two patches are the outcome when I played with ARCH=ia64 builds,
but not prerequisites for 3/3. Anyway I believe they are nice cleanups
and folded in this patch set.

3/3 is the important one to fix the false positive warning,
and it is a nice cleanup too.



Masahiro Yamada (3):
ia64: do not typedef struct pal_min_state_area_s
ia64: remove unneeded header includes from <asm/mca.h>
ia64: remove generated/nr-irqs.h generation to fix build warning

arch/ia64/Makefile | 6 ------
arch/ia64/include/asm/irq.h | 4 +++-
arch/ia64/include/asm/mca.h | 11 ++++-------
arch/ia64/include/asm/pal.h | 4 ++--
arch/ia64/include/asm/sal.h | 2 +-
arch/ia64/kernel/Makefile | 5 -----
arch/ia64/kernel/asm-offsets.c | 18 +++++++++---------
arch/ia64/kernel/efi.c | 1 +
arch/ia64/kernel/mca.c | 5 +++--
arch/ia64/kernel/mca_drv.c | 2 +-
arch/ia64/kernel/nr-irqs.c | 22 ----------------------
11 files changed, 24 insertions(+), 56 deletions(-)
delete mode 100644 arch/ia64/kernel/nr-irqs.c

--
2.25.1

\
 
 \ /
  Last update: 2020-08-29 07:18    [W:0.087 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site