Messages in this thread | | | Subject | Re: [RFC PATCH v7 08/23] sched: Add core wide task selection and scheduling. | From | Vineeth Pillai <> | Date | Fri, 28 Aug 2020 18:15:00 -0400 |
| |
On 8/28/20 4:55 PM, Peter Zijlstra wrote: > On Fri, Aug 28, 2020 at 03:51:09PM -0400, Julien Desfossez wrote: >> + if (is_idle_task(rq_i->core_pick) && rq_i->nr_running) >> + rq_i->core_forceidle = true; > Did you mean: rq_i->core_pick == rq_i->idle ? > > is_idle_task() will also match idle-injection threads, which I'm not > sure we want here. Thanks for catching this. You are right, we should be checking for rq_i->idle. There are couple other places where we use is_idle_task. Will go through them and verify if we need to fix there as well.
Thanks, Vineeth
| |