Messages in this thread | | | Date | Fri, 28 Aug 2020 20:19:28 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error |
| |
On Fri, Aug 28, 2020 at 02:14:48PM -0400, Tong Zhang wrote: > Hi Pablo, > I'm not an expert in this networking stuff. > But from my point of view there's no point in checking if this > condition is always true.
Understood.
> There's also no need of returning anything from the > ct_sip_parse_numerical_param() > if they are all being ignored like this.
Then probably update this code to ignore the return value?
| |