Messages in this thread | | | Subject | Re: [PATCH 1/3] pinctrl: mcp23s08: Fixup mcp23x17 regmap_config | From | Thomas Preston <> | Date | Fri, 28 Aug 2020 18:30:06 +0100 |
| |
On 28/08/2020 10:28, Andy Shevchenko wrote: > On Fri, Aug 28, 2020 at 11:06:21AM +0200, Linus Walleij wrote: >> On Fri, Aug 14, 2020 at 12:04 PM Thomas Preston >> <thomas.preston@codethink.co.uk> wrote: >> >>> - Fix a typo where mcp23x17 configs are referred to as mcp23x16. >>> - Fix precious range to include INTCAP{A,B}, which clear on read. >>> - Fix precious range to include GPIOB, which clears on read. >>> - Fix volatile range to include GPIOB, to fix debugfs registers >>> reporting different values than `gpioget gpiochip2 {0..15}`. >>> >>> Signed-off-by: Thomas Preston <thomas.preston@codethink.co.uk> >> >> Since the other two patches seem wrong, please resend this one patch, >> also include the people on TO: here: Andy, Phil and Jan, who all use >> this chip a lot. > > And it seems it combines a lot of stuff in one patch. Can we have a split with > appropriate Fixes: tags? >
Yeah no problem, just looking at this now.
| |