Messages in this thread | | | Date | Fri, 28 Aug 2020 11:27:25 +0100 | From | Qais Yousef <> | Subject | Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity |
| |
On 08/28/20 10:00, vincent.donnefort@arm.com wrote: > From: Vincent Donnefort <vincent.donnefort@arm.com> > > rq->cpu_capacity is a key element in several scheduler parts, such as EAS > task placement and load balancing. Tracking this value enables testing > and/or debugging by a toolkit. > > Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com> > > diff --git a/include/linux/sched.h b/include/linux/sched.h
[...]
> +int sched_trace_rq_cpu_capacity(struct rq *rq) > +{ > + return rq ? > +#ifdef CONFIG_SMP > + rq->cpu_capacity > +#else > + SCHED_CAPACITY_SCALE > +#endif > + : -1; > +} > +EXPORT_SYMBOL_GPL(sched_trace_rq_cpu_capacity); > +
The placement of this #ifdef looks odd to me. But FWIW
Reviewed-by: Qais Yousef <qais.yousef@arm.com>
Cheers
-- Qais Yousef
| |