Messages in this thread | | | Date | Thu, 27 Aug 2020 17:00:01 +0300 | From | Heikki Krogerus <> | Subject | Re: [PATCH v3 1/3] usb typec: mt6360: Add support for mt6360 Type-C driver |
| |
On Thu, Aug 27, 2020 at 07:18:55PM +0800, cy_huang wrote: > From: ChiYuan Huang <cy_huang@richtek.com> > > Mediatek MT6360 is a multi-functional IC that includes USB Type-C. > It works with Type-C Port Controller Manager to provide USB PD > and USB Type-C functionalities. > > v1 to v2 > 1. Add fix to Prevent the race condition from interrupt and tcpci port > unregister during module remove. > > v2 to v3 > 1. Change comment style for the head of source code. > 2. No need to print error for platform_get_irq_byname. > 3. Fix tcpci_register_port check from IS_ERR_OR_NULL to IS_ERR. > 4. Rename driver/Kconfig/Makefile form mt6360 to mt636x. > 5. Rename DT binding documents from mt6360 to mt636x.
You don't place additional changelog here...
> Signed-off-by: ChiYuan Huang <cy_huang@richtek.com> > ---
You put it here, after that '---' marker: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
> drivers/usb/typec/tcpm/Kconfig | 8 ++ > drivers/usb/typec/tcpm/Makefile | 1 + > drivers/usb/typec/tcpm/tcpci_mt6360.c | 212 ++++++++++++++++++++++++++++++++++ > 3 files changed, 221 insertions(+) > create mode 100644 drivers/usb/typec/tcpm/tcpci_mt6360.c
thanks,
-- heikki
| |