| Date | Thu, 27 Aug 2020 09:24:08 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/9] iomap: Fix misplaced page flushing |
| |
On Mon, Aug 24, 2020 at 03:55:02PM +0100, Matthew Wilcox (Oracle) wrote: > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index bcfc288dba3f..cffd575e57b6 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -715,6 +715,7 @@ iomap_write_end_inline(struct inode *inode, struct page *page, > { > void *addr; > > + flush_dcache_page(page); > WARN_ON_ONCE(!PageUptodate(page)); > BUG_ON(pos + copied > PAGE_SIZE - offset_in_page(iomap->inline_data));
Please move the call down below the asserts.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
|