lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/16] iio: adc: ltc2497: Simplify with dev_err_probe()
    Date
    Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and also it prints the error value.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/iio/adc/ltc2497-core.c | 10 +++-------
    1 file changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/iio/adc/ltc2497-core.c b/drivers/iio/adc/ltc2497-core.c
    index 9b8fd9c32364..2a485c8a1940 100644
    --- a/drivers/iio/adc/ltc2497-core.c
    +++ b/drivers/iio/adc/ltc2497-core.c
    @@ -180,13 +180,9 @@ int ltc2497core_probe(struct device *dev, struct iio_dev *indio_dev)
    return ret;

    ddata->ref = devm_regulator_get(dev, "vref");
    - if (IS_ERR(ddata->ref)) {
    - if (PTR_ERR(ddata->ref) != -EPROBE_DEFER)
    - dev_err(dev, "Failed to get vref regulator: %pe\n",
    - ddata->ref);
    -
    - return PTR_ERR(ddata->ref);
    - }
    + if (IS_ERR(ddata->ref))
    + return dev_err_probe(dev, PTR_ERR(ddata->ref),
    + "Failed to get vref regulator\n");

    ret = regulator_enable(ddata->ref);
    if (ret < 0) {
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-26 16:53    [W:7.415 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site