lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/5] power: supply: ingenic: Simplify with dev_err_probe()
    Date
    Common pattern of handling deferred probe can be simplified with
    dev_err_probe(). Less code and also it prints the error value.

    Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
    ---
    drivers/power/supply/ingenic-battery.c | 8 +++-----
    1 file changed, 3 insertions(+), 5 deletions(-)

    diff --git a/drivers/power/supply/ingenic-battery.c b/drivers/power/supply/ingenic-battery.c
    index dd3d93dfe3eb..32dc77fd9a95 100644
    --- a/drivers/power/supply/ingenic-battery.c
    +++ b/drivers/power/supply/ingenic-battery.c
    @@ -147,11 +147,9 @@ static int ingenic_battery_probe(struct platform_device *pdev)
    psy_cfg.of_node = dev->of_node;

    bat->battery = devm_power_supply_register(dev, desc, &psy_cfg);
    - if (IS_ERR(bat->battery)) {
    - if (PTR_ERR(bat->battery) != -EPROBE_DEFER)
    - dev_err(dev, "Unable to register battery\n");
    - return PTR_ERR(bat->battery);
    - }
    + if (IS_ERR(bat->battery))
    + return dev_err_probe(dev, PTR_ERR(bat->battery),
    + "Unable to register battery\n");

    ret = power_supply_get_battery_info(bat->battery, &bat->info);
    if (ret) {
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-08-26 16:52    [W:2.404 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site