Messages in this thread | | | From | Rob Herring <> | Date | Wed, 26 Aug 2020 08:35:29 -0600 | Subject | Re: [PATCH 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding |
| |
On Wed, Aug 26, 2020 at 12:32 AM Vinod Koul <vkoul@kernel.org> wrote: > > On 25-08-20, 20:21, Vinod Koul wrote: > > Hey Rob, > > > > On 24-08-20, 11:40, Rob Herring wrote: > > > On Mon, 24 Aug 2020 14:17:10 +0530, Vinod Koul wrote: > > > > Add devicetree binding documentation for GPI DMA controller > > > > implemented on Qualcomm SoCs > > > > > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > > > --- > > > > .../devicetree/bindings/dma/qcom-gpi.yaml | 87 +++++++++++++++++++ > > > > 1 file changed, 87 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/dma/qcom-gpi.yaml > > > > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom-gpi.yaml: properties:qcom,ev-factor: {'description': 'Event ring transfer size compare to channel transfer ring. Event ring length = ev-factor * transfer ring size', 'maxItems': 1} is not valid under any of the given schemas (Possible causes of the failure): > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom-gpi.yaml: properties:qcom,ev-factor: 'not' is a required property > > > > Okay updating dt-schema I do see this, now the question is what is this > > and what does it mean ;-) I am not sure I comprehend the error message. > > I see this for all the new properties I added as required for this > > device node > > Okay I think I have figured it out, I need to provide ref to > /schemas/types.yaml#definitions/uint32 for this to work, which does > makes sense to me. > > qcom,max-num-gpii: > $ref: /schemas/types.yaml#definitions/uint32 > maxItems: 1
uint32 is always 1 item, so drop. Is there a max value you can define? Otherwise, up to 2^32 - 1 is valid.
> description: > Number of GPII instances > > Looks good to schema tool > > -- > ~Vinod
| |