lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] HID: google: add google vivaldi HID driver
On Tue, 25 Aug 2020, Sean O'Brien wrote:

> Add Google vivaldi HID driver. This driver allows us to read and report
> the top row layout of keyboards which provide a vendor-defined HID
> usage.

Thanks for the driver.

I actually believe we should follow the standard convention here, and have
just one hid-<vendor> driver for all google products. Currently we have
hid-google-hammer, and this would add hid-google-vivaldi. Would you (or
Wei-Ning, CCing here) object on merging these two together?

It's of course possible to still have hid-google-vivaldi.c and
hid-google-hammer.c, but then have only one CONFIG_HID_GOOGLE option
that'd link these two (and pontentially any future ones) into one single
hid-google.ko.

Thanks,

--
Jiri Kosina
SUSE Labs

\
 
 \ /
  Last update: 2020-08-26 13:14    [W:0.144 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site