lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] spi: spi-fsl-dspi: Add ACPI support
Date


On Mon, Aug 24, 2020 at 19:25, Mark Brown <broonie@kernel.org> wrote:
> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: 2020年8月24日 19:25
> To: Vladimir Oltean <olteanv@gmail.com>
> Cc: kuldip dwivedi <kuldip.dwivedi@puresoftware.com>;
> linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Qiang Zhao
> <qiang.zhao@nxp.com>; Pankaj Bansal <pankaj.bansal@nxp.com>; Varun Sethi
> <V.Sethi@nxp.com>; Tanveer Alam <tanveer.alam@puresoftware.com>
> Subject: Re: [PATCH] spi: spi-fsl-dspi: Add ACPI support
>
> On Sat, Aug 22, 2020 at 06:21:18PM +0300, Vladimir Oltean wrote:
> > On Sat, Aug 22, 2020 at 07:37:25PM +0530, Kuldip Dwivedi wrote:
>
> > > > The whole point with the device property API is that it works with
> > > > both DT and ACPI without needing separate parsing, though in this
> > > > case I'm wondering why we'd need to specify this in an ACPI system
> > > > at all?
>
> > > Understood. Will take care in v2 PATCH
>
> > IMO there is zero reason for the existence of the "spi-num-chipselects"
> > property even for DT. We should deprecate it (start ignoring it in
> > existing device tree deployments) and populate struct
> > fsl_dspi_devtype_data with that info based on SoC compatible string.
>
> Yes, it's a legacy from bad board file conversions and shouldn't be used at all.

I saw a lot of driver assign spi_controller -> num_chipselect directly, should we do like that?

BR
Qiang Zhao
\
 
 \ /
  Last update: 2020-08-26 10:19    [W:0.105 / U:0.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site