lkml.org 
[lkml]   [2020]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/11] cpuidle: Fixup IRQ state
On Fri, Aug 21, 2020 at 07:36:43PM +0200, Rafael J. Wysocki wrote:
> On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote:
> > Match the pattern elsewhere in this file.
> >
> > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Tested-by: Marco Elver <elver@google.com>
>
> For all patches in the series:
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>

thanks,

- Joel

>
> > ---
> > drivers/cpuidle/cpuidle.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > --- a/drivers/cpuidle/cpuidle.c
> > +++ b/drivers/cpuidle/cpuidle.c
> > @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c
> > */
> > stop_critical_timings();
> > drv->states[index].enter_s2idle(dev, drv, index);
> > - WARN_ON(!irqs_disabled());
> > + if (WARN_ON_ONCE(!irqs_disabled()))
> > + local_irq_disable();
> > /*
> > * timekeeping_resume() that will be called by tick_unfreeze() for the
> > * first CPU executing it calls functions containing RCU read-side
> >
> >
> >
>
>
>
>

\
 
 \ /
  Last update: 2020-08-27 03:06    [W:0.194 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site