Messages in this thread | | | Date | Wed, 26 Aug 2020 17:10:05 -0400 | From | Steven Rostedt <> | Subject | Re: localmodconfig - "intel_rapl_perf config not found!!" |
| |
On Tue, 25 Aug 2020 14:34:34 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
> On 8/25/20 2:12 PM, Randy Dunlap wrote: > >> On Tue, Aug 25, 2020 at 2:13 PM Randy Dunlap <rdunlap@infradead.org> wrote: > >>> > >>> so intel_rapl_perf is listed in your lsmod.cfg file: > >>> intel_rapl_perf 16384 2 > >>> > >>> You say Linux 5.8.3. I'm guessing that your "make localmodconfig" tree > >>> is Linux 5.8.3 (?). What kernel version are you running? > >>> I think that it's older, and some file/module names have changed since then. > > > > On 8/25/20 1:34 PM, Nathan Royce wrote: > >> Correct. I'm building for 5.8.3 and I'm currently on 5.7.4 (1 month > >> doesn't seem particularly old). > > > > Yes, things can change quickly.
Yes and as Randy said, there's no way to easily fix that.
> > > > > > I don't see any support in streamline_config.pl for Kconfig symbols > > and/or modules whose names have changed. Trying to do something > > like that would be a never-ending job (a la job security). > > > > At least it gave you a warning that it couldn't find a Kconfig symbol > > for that module.
Correct, this is exactly why I have it warn. Because this happens all the time. In most cases, I simply ignore the warning ;-)
> > > > > > From your original email: > > | I'm going to assume it has something to do with the naming and it's > > | supposed to be associated with "Intel/AMD rapl performance events > > | (CONFIG_PERF_EVENTS_INTEL_RAPL)" which I already have set to 'Y'. > > > > Yes, commit fd3ae1e1587d64ef8cc8e361903d33625458073e changed the module name > > since it now supports both Intel and AMD. > > > > > > | Right below that, I also get 'Use of uninitialized value > > | $ENV{"LMC_KEEP"} in split at ./scripts/kconfig/streamline_config.pl > > | line 596.', but again that is the sort of thing that may warrant a new > > | email specific to localmodconfig author(s). But again maybe not > > | because I take it more as a warning given I don't make use of > > | LMC_KEEP. > > > > > > @Changbin: can you fix this little bug in streamline_config.pl, please? ^^^^^ > > Changing email address for Changbin. > Plus I made the quick patch for streamline_config.pl (below) > although I haven't tested it. > > --- > From: Randy Dunlap <rdunlap@infradead.org> > > A user reported: > 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at > ./scripts/kconfig/streamline_config.pl line 596.' > > so first check that $ENV{LMC_KEEP} is defined before trying > to use it.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Randy, please send this as a stand alone patch to the KBUILD maintainers.
-- Steve
> > Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Changbin Du <changbin.du@gmail.com> > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> > Cc: Masahiro Yamada <masahiroy@kernel.org> > --- > scripts/kconfig/streamline_config.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > --- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl > +++ linux-next-20200825/scripts/kconfig/streamline_config.pl > @@ -593,7 +593,10 @@ while ($repeat) { > } > > my %setconfigs; > -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP}); > +my @preserved_kconfigs; > +if (defined($ENV{'LMC_KEEP'})) { > + @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP}); > +} > > sub in_preserved_kconfigs { > my $kconfig = $config2kfile{$_[0]};
| |