Messages in this thread | | | Date | Wed, 26 Aug 2020 17:53:08 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] ASoC: fsl_spdif: Fix unnecessary check in fsl_spdif_probe() |
| |
On Wed, Aug 26, 2020 at 11:09:18PM +0800, Tang Bin wrote: > The function fsl_spdif_probe() is only called with an openfirmware > platform device. Therefore there is no need to check that the passed > in device is NULL.
Why is this an issue - the check will make things more robust if someone manages to load the driver on a non-DT system and otherwise costs us a couple of instructions? [unhandled content-type:application/pgp-signature] | |