lkml.org 
[lkml]   [2020]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller
From
Date
> On 24-08-20, 13:11, Sanjay R Mehta wrote:
>> Apologies for my delayed response.
>>
>> On 7/3/2020 12:48 PM, Vinod Koul wrote:
>>> [CAUTION: External Email]
>>>
>>> On 16-06-20, 20:11, Sanjay R Mehta wrote:
>>>
>>>> +static int pt_core_execute_cmd(struct ptdma_desc *desc,
>>>> + struct pt_cmd_queue *cmd_q)
>>>> +{
>>>> + __le32 *mp;
>>>> + u32 *dp;
>>>> + u32 tail;
>>>> + int i;
>>>
>>> no tabs, spaces pls
>> Sure, will fix in the next version of patch.
>
> Also, please make sure you run checkpatch.pl with --strict option, that
> will help out reducing the churn here
>
Thanks Vinod. Will make sure to run the checkpatch.pl with --strict option.

Also, please do let me know if I am missing anything else too.
I will make sure to submit those changes too in the next version of patch series.

> Thanks
> --
> ~Vinod
>

\
 
 \ /
  Last update: 2020-08-25 13:34    [W:0.053 / U:3.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site