lkml.org 
[lkml]   [2020]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 1/1] extcon: ptn5150: Add usb-typec support for Intel LGM SoC
From
Date
Hi,

Thank you for the review comments...

On 25/8/2020 4:40 pm, Krzysztof Kozlowski wrote:
> On Tue, Aug 25, 2020 at 04:31:47PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add usb-typec detection support for Intel LGM SoC based
>> boards.
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> ---
>> drivers/extcon/extcon-ptn5150.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>> index 8ba706fad887..60355a1b5cb2 100644
>> --- a/drivers/extcon/extcon-ptn5150.c
>> +++ b/drivers/extcon/extcon-ptn5150.c
>> @@ -300,6 +300,8 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>> return ret;
>> }
>>
>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>
> Hi,
>
> I think you need the same for EXTCON_USB.
>
> Although extcon_set_property_capability() error should not be fatal, but
> printing a warn message would be useful.
Yes , earlier we had like below settings in our patches,
+ extcon_set_property_capability(info->edev, EXTCON_USB,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_VBUS);
+ extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
+ EXTCON_PROP_USB_TYPEC_POLARITY);

sure, will add warn message as well.

Thanks!
Best Regards
Vadivel
>
> Best regards,
> Krzysztof
>
>
>> /* Initialize PTN5150 device and print vendor id and version id */
>> ret = ptn5150_init_dev_type(info);
>> if (ret)
>> --
>> 2.11.0
>>

\
 
 \ /
  Last update: 2020-08-25 11:17    [W:0.162 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site