Messages in this thread | | | Date | Tue, 25 Aug 2020 09:10:24 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH] nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()' |
| |
On Fri, Aug 21, 2020 at 09:58:19AM +0200, Christophe JAILLET wrote: > The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent > in this function. > > Use 'spin_lock_irqsave()' also here, as there is no guarantee that > interruptions are disabled at that point, according to surrounding code. > > Fixes: a97ec51b37ef ("nvmet_fc: Rework target side abort handling") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Not tested, only based on what looks logical to me according to > surrounding code
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |