lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] workqueue: Warning when work try to flush own workqueue
Date
From: Qianli Zhao <zhaoqianli@xiaomi.com>

In a work process context,flush own workqueue or work self
will cause process blocked(enter state D),leading to a
deadlock,catch this wrong use,warn when the issue happened

crash> ps 10856
PID PPID CPU TASK ST COMM
10856 2 2 ffffffc873428080 UN [kworker/u16:15]
crash> bt 10856
PID: 10856 TASK: ffffffc873428080 CPU: 2 COMMAND: "kworker/u16:15"
#0 [ffffff80270cb9a0] __switch_to at ffffff99bba8533c
#1 [ffffff80270cba30] __schedule at ffffff99bcda18dc
#2 [ffffff80270cba50] schedule at ffffff99bcda1cdc
#3 [ffffff80270cbaf0] schedule_timeout at ffffff99bcda6674
#4 [ffffff80270cbb70] wait_for_common at ffffff99bcda2c68
#5 [ffffff80270cbb80] wait_for_completion at ffffff99bcda2b60
#6 [ffffff80270cbc30] flush_workqueue at ffffff99bbad7a60
#7 [ffffff80270cbc90] drain_workqueue at ffffff99bbad80fc
#8 [ffffff80270cbcb0] destroy_workqueue at ffffff99bbad92f8
#9 [ffffff80270cbda0] dfc_svc_init at ffffff99bbfbfb6c
#10 [ffffff80270cbdf0] process_one_work at ffffff99bbadc478
#11 [ffffff80270cbe50] worker_thread at ffffff99bbadc9dc
#12 [ffffff80270cbeb0] kthread at ffffff99bbae1f84

Signed-off-by: Qianli Zhao <zhaoqianli@xiaomi.com>
---
kernel/workqueue.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 3f5d4bf..759280d 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -2585,6 +2585,8 @@ static int rescuer_thread(void *__rescuer)
* @target_work: work item being flushed (NULL for workqueue flushes)
*
* %current is trying to flush the whole @target_wq or @target_work on it.
+ * If a work try to flush own workqueue or itself will cause process blocked,
+ * leading to a dealock.
* If @target_wq doesn't have %WQ_MEM_RECLAIM, verify that %current is not
* reclaiming memory or running on a workqueue which doesn't have
* %WQ_MEM_RECLAIM as that can break forward-progress guarantee leading to
@@ -2594,13 +2596,16 @@ static void check_flush_dependency(struct workqueue_struct *target_wq,
struct work_struct *target_work)
{
work_func_t target_func = target_work ? target_work->func : NULL;
- struct worker *worker;
+ struct worker *worker = current_wq_worker();
+
+ WARN_ONCE(worker && worker->current_pwq->wq == target_wq &&
+ worker->task == current,
+ "workqueue: current work function:%ps is flushing own workqueue:%s",
+ worker->current_func, target_wq->name);

if (target_wq->flags & WQ_MEM_RECLAIM)
return;

- worker = current_wq_worker();
-
WARN_ONCE(current->flags & PF_MEMALLOC,
"workqueue: PF_MEMALLOC task %d(%s) is flushing !WQ_MEM_RECLAIM %s:%ps",
current->pid, current->comm, target_wq->name, target_func);
--
2.7.4
\
 
 \ /
  Last update: 2020-08-24 13:21    [W:0.032 / U:1.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site