lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 32/71] cpufreq: intel_pstate: Fix cpuinfo_max_freq when MSR_TURBO_RATIO_LIMIT is 0
    Date
    From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>

    [ Upstream commit 4daca379c703ff55edc065e8e5173dcfeecf0148 ]

    The MSR_TURBO_RATIO_LIMIT can be 0. This is not an error. User can update
    this MSR via BIOS settings on some systems or can use msr tools to update.
    Also some systems boot with value = 0.

    This results in display of cpufreq/cpuinfo_max_freq wrong. This value
    will be equal to cpufreq/base_frequency, even though turbo is enabled.

    But platform will still function normally in HWP mode as we get max
    1-core frequency from the MSR_HWP_CAPABILITIES. This MSR is already used
    to calculate cpu->pstate.turbo_freq, which is used for to set
    policy->cpuinfo.max_freq. But some other places cpu->pstate.turbo_pstate
    is used. For example to set policy->max.

    To fix this, also update cpu->pstate.turbo_pstate when updating
    cpu->pstate.turbo_freq.

    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/cpufreq/intel_pstate.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
    index e7b3d4ed8eff4..99166000ffb77 100644
    --- a/drivers/cpufreq/intel_pstate.c
    +++ b/drivers/cpufreq/intel_pstate.c
    @@ -1431,6 +1431,7 @@ static void intel_pstate_get_cpu_pstates(struct cpudata *cpu)

    intel_pstate_get_hwp_max(cpu->cpu, &phy_max, &current_max);
    cpu->pstate.turbo_freq = phy_max * cpu->pstate.scaling;
    + cpu->pstate.turbo_pstate = phy_max;
    } else {
    cpu->pstate.turbo_freq = cpu->pstate.turbo_pstate * cpu->pstate.scaling;
    }
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-24 11:14    [W:4.033 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site