lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 24/71] rtc: goldfish: Enable interrupt in set_alarm() when necessary
    Date
    From: Huacai Chen <chenhc@lemote.com>

    [ Upstream commit 22f8d5a1bf230cf8567a4121fc3789babb46336d ]

    When use goldfish rtc, the "hwclock" command fails with "select() to
    /dev/rtc to wait for clock tick timed out". This is because "hwclock"
    need the set_alarm() hook to enable interrupt when alrm->enabled is
    true. This operation is missing in goldfish rtc (but other rtc drivers,
    such as cmos rtc, enable interrupt here), so add it.

    Signed-off-by: Huacai Chen <chenhc@lemote.com>
    Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Link: https://lore.kernel.org/r/1592654683-31314-1-git-send-email-chenhc@lemote.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/rtc/rtc-goldfish.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c
    index a1c44d0c85578..30cbe22c57a8e 100644
    --- a/drivers/rtc/rtc-goldfish.c
    +++ b/drivers/rtc/rtc-goldfish.c
    @@ -87,6 +87,7 @@ static int goldfish_rtc_set_alarm(struct device *dev,
    rtc_alarm64 = rtc_alarm * NSEC_PER_SEC;
    writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH);
    writel(rtc_alarm64, base + TIMER_ALARM_LOW);
    + writel(1, base + TIMER_IRQ_ENABLED);
    } else {
    /*
    * if this function was called with enabled=0
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-24 11:01    [W:7.308 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site