lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] scsi: qla2xxx: Remove unnecessary call to memset
    From
    Date
    On 2020-08-20 19:51, Alex Dewar wrote:
    > In qla25xx_set_els_cmds_supported(), a call is made to
    > dma_alloc_coherent() followed by zeroing the memory with memset. This is
    > unnecessary as dma_alloc_coherent() already zeros memory. Remove.
    >
    > Issue identified with Coccinelle.
    >
    > Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
    Gentle ping?
    > ---
    > drivers/scsi/qla2xxx/qla_mbx.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
    > index 226f1428d3e5..e00f604bbf7a 100644
    > --- a/drivers/scsi/qla2xxx/qla_mbx.c
    > +++ b/drivers/scsi/qla2xxx/qla_mbx.c
    > @@ -4925,8 +4925,6 @@ qla25xx_set_els_cmds_supported(scsi_qla_host_t *vha)
    > return QLA_MEMORY_ALLOC_FAILED;
    > }
    >
    > - memset(els_cmd_map, 0, ELS_CMD_MAP_SIZE);
    > -
    > /* List of Purex ELS */
    > cmd_opcode[0] = ELS_FPIN;
    > cmd_opcode[1] = ELS_RDP;

    \
     
     \ /
      Last update: 2020-08-24 23:43    [W:3.599 / U:0.428 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site