lkml.org 
[lkml]   [2020]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v18 07/32] mm/swap.c: stop deactivate_file_page if page not on lru
    Date
    Keeping deactivate_file_page is useless if page isn't on lru list. So
    let's stop it.

    Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
    Cc: Hugh Dickins <hughd@google.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Michal Hocko <mhocko@kernel.org>
    Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: linux-kernel@vger.kernel.org
    Cc: cgroups@vger.kernel.org
    Cc: linux-mm@kvack.org
    ---
    mm/swap.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/swap.c b/mm/swap.c
    index c674fb441fe9..ea9e1f538313 100644
    --- a/mm/swap.c
    +++ b/mm/swap.c
    @@ -671,7 +671,7 @@ void deactivate_file_page(struct page *page)
    * In a workload with many unevictable page such as mprotect,
    * unevictable page deactivation for accelerating reclaim is pointless.
    */
    - if (PageUnevictable(page))
    + if (PageUnevictable(page) || !PageLRU(page))
    return;

    if (likely(get_page_unless_zero(page))) {
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2020-08-24 14:59    [W:7.702 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site