Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 22 Aug 2020 13:35:25 +0900 | Subject | Re: [PATCH v2 6/9] gen_compile_commands: move directory walk to a generator function |
| |
On Sat, Aug 22, 2020 at 9:41 AM 'Nick Desaulniers' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote:
> > + for path in paths: > > + cmdfiles = cmdfiles_in_dir(path) > > + > > + for cmdfile in cmdfiles: > > If `cmdfiles` is never referenced again, please make this: > > for cmdfile in cmdfiles_in_dir(path):
I intentionally wrote in this way because in the next commit, cmdfiles will be selectively set.
> With those 2 changes feel free to add my > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > > > + with open(cmdfile, 'rt') as f: > > result = line_matcher.match(f.readline()) > > if result: > > try: > > - entry = process_line(directory, > > - result.group(1), result.group(2)) > > + entry = process_line(directory, result.group(1), > > + result.group(2)) > > compile_commands.append(entry) > > except ValueError as err: > > logging.info('Could not add line from %s: %s', > > - filepath, err) > > + cmdfile, err) > > > > with open(output, 'wt') as f: > > json.dump(compile_commands, f, indent=2, sort_keys=True) > > -- > > 2.25.1 > > > > > -- > Thanks, > ~Nick Desaulniers > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/CAKwvOdn9ZfvC4dzuVnxc_a52JFn_q1ewOWwZZD5b9%3DizeEayKQ%40mail.gmail.com.
-- Best Regards Masahiro Yamada
| |