lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 13/30] drm/amd/display: fix ref count leak in amdgpu_drm_ioctl
    Date
    From: Navid Emamdoost <navid.emamdoost@gmail.com>

    [ Upstream commit 5509ac65f2fe5aa3c0003237ec629ca55024307c ]

    in amdgpu_drm_ioctl the call to pm_runtime_get_sync increments the
    counter even in case of failure, leading to incorrect
    ref count. In case of failure, decrement the ref count before returning.

    Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    index ae23f7e0290c3..465ece90e63ab 100644
    --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
    @@ -801,11 +801,12 @@ long amdgpu_drm_ioctl(struct file *filp,
    dev = file_priv->minor->dev;
    ret = pm_runtime_get_sync(dev->dev);
    if (ret < 0)
    - return ret;
    + goto out;

    ret = drm_ioctl(filp, cmd, arg);

    pm_runtime_mark_last_busy(dev->dev);
    +out:
    pm_runtime_put_autosuspend(dev->dev);
    return ret;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-08-21 18:51    [W:4.101 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site