Messages in this thread | | | Subject | Re: [PATCH] soundwire: intel: fix CONFIG_PM and CONFIG_PM_SLEEP confusion | From | Pierre-Louis Bossart <> | Date | Fri, 21 Aug 2020 10:23:53 -0500 |
| |
>> When CONFIG_PM_SLEEP is not defined, GCC throws compilation warnings: >> >> drivers/soundwire/intel.c:1816:12: warning: ‘intel_resume’ defined but >> not used [-Wunused-function] >> 1816 | static int intel_resume(struct device *dev) >> | ^~~~~~~~~~~~ >> >> drivers/soundwire/intel.c:1697:12: warning: ‘intel_suspend’ defined >> but not used [-Wunused-function] >> 1697 | static int intel_suspend(struct device *dev) >> >> Fix by adding the missing CONFIG_PM_SLEEP. > > Can you rather use __maybe for for these rather than wrapping in another > ifdef, that is the recommended way to do this
No objections, that would work as well.
| |