Messages in this thread Patch in this message | | | From | YueHaibing <> | Subject | [PATCH v3] scsi: libfc: Fix passing zero to 'PTR_ERR' warning | Date | Fri, 21 Aug 2020 19:02:56 +0800 |
| |
drivers/scsi/libfc/fc_disc.c:304 fc_disc_error() warn: passing zero to 'PTR_ERR'
fp maybe NULL in fc_disc_error(), use PTR_ERR_OR_ZERO to handle this.
Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v3: use PTR_ERR_OR_ZERO v2: use use IS_ERR in fc_disc_error() --- drivers/scsi/libfc/fc_disc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c index d8cbc9c0e766..43284c3b2903 100644 --- a/drivers/scsi/libfc/fc_disc.c +++ b/drivers/scsi/libfc/fc_disc.c @@ -302,7 +302,7 @@ static void fc_disc_error(struct fc_disc *disc, struct fc_frame *fp) unsigned long delay = 0; FC_DISC_DBG(disc, "Error %ld, retries %d/%d\n", - PTR_ERR(fp), disc->retry_count, + PTR_ERR_OR_ZERO(fp), disc->retry_count, FC_DISC_RETRY_LIMIT); if (!fp || PTR_ERR(fp) == -FC_EX_TIMEOUT) { -- 2.17.1
| |