Messages in this thread | | | Date | Fri, 21 Aug 2020 11:18:39 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v8 1/3] devres: provide devm_krealloc() |
| |
On Fri, Aug 21, 2020 at 11:15:55AM +0300, Andy Shevchenko wrote: > On Thu, Aug 20, 2020 at 08:51:08PM +0200, Bartosz Golaszewski wrote:
...
> > +static struct devres *to_devres(void *data) > > +{ > > + return data - ALIGN(sizeof(struct devres), ARCH_KMALLOC_MINALIGN); > > +} > > + > > +static size_t devres_data_size(size_t total_size) > > +{ > > + return total_size - ALIGN(sizeof(struct devres), ARCH_KMALLOC_MINALIGN); > > +} > > I'm fine with above, but here is a side note, perhaps > > offsetof(struct devres, data) > > will be more practical (no duplication of alignment and hence slightly better > maintenance)? (Note, I didn't check if it provides the correct result)
And if the result is correct wouldn't be first a simple container_of() after all?
> Another side note: do we have existing users of these helpers?
-- With Best Regards, Andy Shevchenko
| |