Messages in this thread | | | Date | Fri, 21 Aug 2020 18:05:06 +1000 | From | Herbert Xu <> | Subject | Re: [PATCH 4.19 012/168] crypto: ccree - fix resource leak on error path |
| |
On Tue, Aug 18, 2020 at 11:22:31AM +0200, Pavel Machek wrote: > > But it is freed unconditionally, and free_shash() is not robust > against NULL pointer due to undefined behaviour in crypto_shash_tfm.
crypto_free_shash calls crypto_destroy_tfm with both the original pointer as well as the crypto_shash_tfm pointer so it does the right thing for NULL pointers. Please check again.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |