lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] memory: brcmstb_dpfe: fix array index out of bounds
Hi Markus,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc1 next-20200820]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Markus-Mayer/memory-brcmstb_dpfe-fix-array-index-out-of-bounds/20200821-090533
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da2968ff879b9e74688cdc658f646971991d2c56
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/memory/brcmstb_dpfe.c:305:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
305 | static const char * const get_error_text(unsigned int i)
| ^~~~~

# https://github.com/0day-ci/linux/commit/a2de88715f98369b7e4478457a6455c3e2c72725
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Markus-Mayer/memory-brcmstb_dpfe-fix-array-index-out-of-bounds/20200821-090533
git checkout a2de88715f98369b7e4478457a6455c3e2c72725
vim +305 drivers/memory/brcmstb_dpfe.c

304
> 305 static const char * const get_error_text(unsigned int i)
306 {
307 static const char * const error_text[] = {
308 "Success", "Header code incorrect",
309 "Unknown command or argument", "Incorrect checksum",
310 "Malformed command", "Timed out", "Unknown error",
311 };
312
313 if (unlikely(i >= ARRAY_SIZE(error_text)))
314 i = ARRAY_SIZE(error_text) - 1;
315
316 return error_text[i];
317 }
318

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2020-08-21 06:46    [W:0.134 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site