lkml.org 
[lkml]   [2020]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 05/11] genirq: Shutdown irq chips in suspend/resume during hibernation
    Date
    On Fri, Aug 21 2020 at 22:27, Thomas Gleixner wrote:
    > Add a new quirk flag IRQCHIP_SHUTDOWN_ON_SUSPEND and add support for
    > it the core interrupt suspend/resume paths.
    >
    > Changelog:
    > v1->v2: Corrected the author's name to tglx@

    Can you please move that Changelog part below the --- seperator next
    time because that's really not part of the final commit messaage and the
    maintainer has then to strip it off manually

    > Signed-off-by: Anchal Agarwal <anchalag@amazon.com>
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

    These SOB lines are just wrongly ordered as they suggest:

    Anchal has authored the patch and Thomas transported it

    which is clearly not the case. So the right order is:

    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Anchal Agarwal <anchalag@amazon.com>

    And that needs another tweak at the top of the change log. The first
    line in the mail body wants to be:

    From: Thomas Gleixner <tglx@linutronix.de>

    followed by an empty new line before the actual changelog text
    starts. That way the attribution of the patch when applying it will be
    correct.

    Documentation/process/ is there for a reason and following the few
    simple rules to get that straight is not rocket science.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2020-08-22 02:37    [W:6.076 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site