lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 113/228] MIPS: OCTEON: add missing put_device() call in dwc3_octeon_device_init()
    Date
    From: Yu Kuai <yukuai3@huawei.com>

    [ Upstream commit e8b9fc10f2615b9a525fce56981e40b489528355 ]

    if of_find_device_by_node() succeed, dwc3_octeon_device_init() doesn't have
    a corresponding put_device(). Thus add put_device() to fix the exception
    handling for this function implementation.

    Fixes: 93e502b3c2d4 ("MIPS: OCTEON: Platform support for OCTEON III USB controller")
    Signed-off-by: Yu Kuai <yukuai3@huawei.com>
    Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/mips/cavium-octeon/octeon-usb.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/arch/mips/cavium-octeon/octeon-usb.c b/arch/mips/cavium-octeon/octeon-usb.c
    index bfdfaf32d2c49..75189ff2f3c78 100644
    --- a/arch/mips/cavium-octeon/octeon-usb.c
    +++ b/arch/mips/cavium-octeon/octeon-usb.c
    @@ -517,6 +517,7 @@ static int __init dwc3_octeon_device_init(void)

    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    if (res == NULL) {
    + put_device(&pdev->dev);
    dev_err(&pdev->dev, "No memory resources\n");
    return -ENXIO;
    }
    @@ -528,8 +529,10 @@ static int __init dwc3_octeon_device_init(void)
    * know the difference.
    */
    base = devm_ioremap_resource(&pdev->dev, res);
    - if (IS_ERR(base))
    + if (IS_ERR(base)) {
    + put_device(&pdev->dev);
    return PTR_ERR(base);
    + }

    mutex_lock(&dwc3_octeon_clocks_mutex);
    dwc3_octeon_clocks_start(&pdev->dev, (u64)base);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-20 13:08    [W:3.581 / U:0.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site