lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 106/232] gfs2: Fix refcount leak in gfs2_glock_poke
    Date
    From: Andreas Gruenbacher <agruenba@redhat.com>

    commit c07bfb4d8fa1ee11c6d18b093d0bb6c8832d3626 upstream.

    In gfs2_glock_poke, make sure gfs2_holder_uninit is called on the local
    glock holder. Without that, we're leaking a glock and a pid reference.

    Fixes: 9e8990dea926 ("gfs2: Smarter iopen glock waiting")
    Cc: stable@vger.kernel.org # v5.8+
    Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/gfs2/glock.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/fs/gfs2/glock.c
    +++ b/fs/gfs2/glock.c
    @@ -790,9 +790,11 @@ static void gfs2_glock_poke(struct gfs2_
    struct gfs2_holder gh;
    int error;

    - error = gfs2_glock_nq_init(gl, LM_ST_SHARED, flags, &gh);
    + gfs2_holder_init(gl, LM_ST_SHARED, flags, &gh);
    + error = gfs2_glock_nq(&gh);
    if (!error)
    gfs2_glock_dq(&gh);
    + gfs2_holder_uninit(&gh);
    }

    static bool gfs2_try_evict(struct gfs2_glock *gl)

    \
     
     \ /
      Last update: 2020-08-20 11:30    [W:4.434 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site