Messages in this thread | | | From | Chun-Kuang Hu <> | Date | Fri, 21 Aug 2020 07:44:40 +0800 | Subject | Re: [PATCH v1 08/21] drm/mediatek: check if fb is null |
| |
Hi, Yongqiang:
Yongqiang Niu <yongqiang.niu@mediatek.com> 於 2020年8月20日 週四 下午2:06寫道: > > It's possible that state->base.fb is null. Add a check before access its > format.
Add a Fixes tag.
Regards, Chun-Kuang.
> > Signed-off-by: Yongqiang Niu <yongqiang.niu@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > index 427fe7f..2506803 100644 > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c > @@ -269,7 +269,7 @@ static void mtk_ovl_layer_config(struct mtk_ddp_comp *comp, unsigned int idx, > } > > con = ovl_fmt_convert(ovl, fmt); > - if (state->base.fb->format->has_alpha) > + if (state->base.fb && state->base.fb->format->has_alpha) > con |= OVL_CON_AEN | OVL_CON_ALPHA; > > if (pending->rotation & DRM_MODE_REFLECT_Y) { > -- > 1.8.1.1.dirty > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
| |