Messages in this thread | | | Subject | Re: [PATCH v2] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps | From | Christian König <> | Date | Thu, 20 Aug 2020 11:01:29 +0200 |
| |
Am 20.08.20 um 09:52 schrieb Furquan Shaikh: > In `amdgpu_dm_update_backlight_caps()`, there is a local > `amdgpu_dm_backlight_caps` object that is filled in by > `amdgpu_acpi_get_backlight_caps()`. However, this object is > uninitialized before the call and hence the subsequent check for > aux_support can fail since it is not initialized by > `amdgpu_acpi_get_backlight_caps()` as well. This change initializes > this local `amdgpu_dm_backlight_caps` object to 0. > > Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> --- > v2: Switched to using memset for initialization of object. > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index e4b33c67b634..da072998ce48 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -2855,6 +2855,8 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm) > #if defined(CONFIG_ACPI) > struct amdgpu_dm_backlight_caps caps; > > + memset(&caps, 0, sizeof(caps)); > + > if (dm->backlight_caps.caps_valid) > return; >
| |