lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mfd: Add ACPI support to Kontron PLD driver
Date
Thank you for taking the time to review the patch!
Additional comments below, patch v2 will follow.

On Wed, 2020-08-19 at 11:15 +0100, Lee Jones wrote:
> On Wed, 12 Aug 2020, Michael Brunner wrote:
...
> > +#ifdef CONFIG_ACPI
>
> Not keen on #ifdefery if at all avoidable.
>
> Can you use if (IS_ENABLED(CONFIG_ACPI)) at the call-site instead?
>
> The compiler should take care of the rest, no?

Unfortunately acpi_dev_get_resources is not defined when compiling with
CONFIG_ACPI disabled, therefore #ifdef seems to be the only choice.

> > +static const struct acpi_device_id kempld_acpi_table[] = {
> > + { "KEM0001", (kernel_ulong_t)&kempld_platform_data_generic },
> > + {}
> > +};
> > +MODULE_DEVICE_TABLE(acpi, kempld_acpi_table);
>
> I'd prefer if this was moved down to just above where it's used
> i.e. where we usually place the of_device_id tables.

No problem, will update this.

...
> > + INIT_LIST_HEAD(&resource_list);
> > + ret = acpi_dev_get_resources(acpi_dev, &resource_list, NULL,
> > NULL);
> > + if (ret < 0)
> > + goto out;
> > +
> > + count = ret;
>
> if (count == 0) {
> ret = platform_device_add_resources(pdev, pdata-
> >ioresource, 1);
> goto out;
> }
>
> Then drop the next check and pull the indented code back:

Agreed, looks better.

> > + if (count > 0) {
> > + resources = devm_kcalloc(&acpi_dev->dev, count,
> > + sizeof(struct resource),
> > GFP_KERNEL);
>
> sizeof(*resources) is preferred.

Ok

...
> > static int kempld_probe(struct platform_device *pdev)
> > {
> > - const struct kempld_platform_data *pdata =
> > - dev_get_platdata(&pdev->dev);
> > + const struct kempld_platform_data *pdata;
> > struct device *dev = &pdev->dev;
> > struct kempld_device_data *pld;
> > struct resource *ioport;
> > + int ret;
> > +
> > + if (kempld_pdev == NULL) {
>
> Comment please. What does !kempld_pdev actually imply?

If kempld_pdev is not defined, this means no platform device has been
created using the DMI id table and we are currently probing the ACPI
based platform device.
Will add a comment to the code.

> > + ret = kempld_get_acpi_data(pdev);
> > + if (ret < 0)
> > + return ret;
>
> Is 'ret > 0' valid?
>
> If not, then just 'if (ret)'.

Ok

> > + kempld_acpi_mode = true;
> > + } else if (kempld_pdev != pdev) {
> > + dev_notice(dev, "platform device exists - not using
> > ACPI\n");
>
> Why dev_notice() and not dev_err()?
>
> Is that what 'kempld_pdev != pdev' means?
>
> Could you explain this to me in more depth please?

kempld_pdev is the DMI based platform device created in kempld_init
(through force_device_id or dmi_check_system). pdev is the one passed
by the probe function. (kempdl_pdev != pdev) means pdev is the device
created using the ACPI table. As there is only one physical device and
the DMI based version should have priority, the probe is aborted at
this point. As it is not an error condition, only a notice is created
to indicate that ACPI is not used for probing the device.

> > ...
> > @@ -809,12 +887,19 @@ static int __init kempld_init(void)
> > break;
> > if (id->matches[0].slot == DMI_NONE)
> > return -ENODEV;
> > - } else {
> > - if (!dmi_check_system(kempld_dmi_table))
> > - return -ENODEV;
> > }
> >
> > - return platform_driver_register(&kempld_driver);
> > + ret = platform_driver_register(&kempld_driver);
> > + if (ret)
> > + return ret;
>
> Is it guaranteed that the child device has probed at this point?

To my understanding, with synchronous probing it should. According to
the definition of the probe_type enum this is still the default for all
drivers.
I guess it would make sense to enforce this for the case the default is
changed in the future.
Added this to v2:
.probe_type = PROBE_FORCE_SYNCHRONOUS,

Only exception, to my knowledge, is if drivers_autoprobe is disabled
for platform drivers during kempld_init. As DMI has priority, the
driver will later only allow to manually bind the DMI platform device,
if ACPI and DMI are both supported on a platform.

> > + if (!kempld_pdev && !kempld_acpi_mode)
>
> Again, comment please. What has gone on to get to this point?

At this point it is checked if the kempld_pdev has been already created
(force_device_id parameter) and if the ACPI based probe has been
already successfull. If not, the DMI table is searched for a matching
device ID. Doing this at this point should prevent unnecessarily
checking the DMI table.

> > + if (!dmi_check_system(kempld_dmi_table)) {
> > + platform_driver_unregister(&kempld_driver);
> > + return -ENODEV;
> > + }

While writing the above comments I noticed that unregistering the
driver at this point prevents manually binding the driver to a device
if drivers_autoprobe is set to 0. This only made sense as long as DMI
based detection was the only method supported. Therefore I removed it
in v2.

Michael

\
 
 \ /
  Last update: 2020-08-20 17:39    [W:0.055 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site