lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.8 054/232] pinctrl: ingenic: Properly detect GPIO direction when configured for IRQ
    Date
    From: Paul Cercueil <paul@crapouillou.net>

    commit 84e7a946da71f678affacea301f6d5cb4d9784e8 upstream.

    The PAT1 register contains information about the IRQ type (edge/level)
    for input GPIOs with IRQ enabled, and the direction for non-IRQ GPIOs.
    So it makes sense to read it only if the GPIO has no interrupt
    configured, otherwise input GPIOs configured for level IRQs are
    misdetected as output GPIOs.

    Fixes: ebd6651418b6 ("pinctrl: ingenic: Implement .get_direction for GPIO chips")
    Reported-by: João Henrique <johnnyonflame@hotmail.com>
    Signed-off-by: Paul Cercueil <paul@crapouillou.net>
    Cc: stable@vger.kernel.org
    Link: https://lore.kernel.org/r/20200622214548.265417-2-paul@crapouillou.net
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/pinctrl/pinctrl-ingenic.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/pinctrl/pinctrl-ingenic.c
    +++ b/drivers/pinctrl/pinctrl-ingenic.c
    @@ -1955,7 +1955,8 @@ static int ingenic_gpio_get_direction(st
    unsigned int pin = gc->base + offset;

    if (jzpc->info->version >= ID_JZ4760) {
    - if (ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PAT1))
    + if (ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_INT) ||
    + ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PAT1))
    return GPIO_LINE_DIRECTION_IN;
    return GPIO_LINE_DIRECTION_OUT;
    }

    \
     
     \ /
      Last update: 2020-08-20 15:56    [W:5.209 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site