lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart
Date
Add sleep pin ctrl for BT uart, and also change the bias
configuration to match Bluetooth module.

Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
- This patch adds sleep state for BT UART. Newly added in V2.

Changes in V3:
- Remove "output-high" for TX from both sleep and default states
as it is not required. Configure pull-up for TX in sleep state.

arch/arm64/boot/dts/qcom/sc7180-idp.dts | 54 +++++++++++++++++++++++++++------
1 file changed, 45 insertions(+), 9 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index d8b5507..806f626 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -473,20 +473,20 @@

&qup_uart3_default {
pinconf-cts {
- /*
- * Configure a pull-down on 38 (CTS) to match the pull of
- * the Bluetooth module.
- */
+ /* Configure no pull on 38 (CTS) to match Bluetooth module */
pins = "gpio38";
- bias-pull-down;
- output-high;
+ bias-disable;
};

pinconf-rts {
- /* We'll drive 39 (RTS), so no pull */
+ /*
+ * Configure pull-down on 39 (RTS). This is needed to avoid a
+ * floating pin which could mislead Bluetooth controller
+ * with UART RFR state (READY/NOT_READY).
+ */
pins = "gpio39";
drive-strength = <2>;
- bias-disable;
+ bias-pull-down;
};

pinconf-tx {
@@ -494,7 +494,43 @@
pins = "gpio40";
drive-strength = <2>;
bias-disable;
- output-high;
+ };
+
+ pinconf-rx {
+ /*
+ * Configure a pull-up on 41 (RX). This is needed to avoid
+ * garbage data when the TX pin of the Bluetooth module is
+ * in tri-state (module powered off or not driving the
+ * signal yet).
+ */
+ pins = "gpio41";
+ bias-pull-up;
+ };
+};
+
+&qup_uart3_sleep {
+ pinconf-cts {
+ /* Configure no-pull on 38 (CTS) to match Bluetooth module */
+ pins = "gpio38";
+ bias-disable;
+ };
+
+ pinconf-rts {
+ /*
+ * Configure pull-down on 39 (RTS). This is needed to avoid a
+ * floating pin which could mislead Bluetooth controller
+ * with UART RFR state (READY/NOT_READY).
+ */
+ pins = "gpio39";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ pinconf-tx {
+ /* Configure pull-up on 40 (TX) when it isn't actively driven */
+ pins = "gpio40";
+ drive-strength = <2>;
+ bias-pull-up;
};

pinconf-rx {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
\
 
 \ /
  Last update: 2020-08-20 15:53    [W:0.083 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site