lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.7 132/204] f2fs: compress: fix to avoid memory leak on cc->cpages
    Date
    From: Chao Yu <yuchao0@huawei.com>

    [ Upstream commit 02772fbfcba8597eef9d5c5f7f94087132d0c1d4 ]

    Memory allocated for storing compressed pages' poitner should be
    released after f2fs_write_compressed_pages(), otherwise it will
    cause memory leak issue.

    Signed-off-by: Chao Yu <yuchao0@huawei.com>
    Fixes: 4c8ff7095bef ("f2fs: support data compression")
    Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/f2fs/compress.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
    index a5b2e72174bb1..527d50edcb956 100644
    --- a/fs/f2fs/compress.c
    +++ b/fs/f2fs/compress.c
    @@ -1250,6 +1250,8 @@ int f2fs_write_multi_pages(struct compress_ctx *cc,
    err = f2fs_write_compressed_pages(cc, submitted,
    wbc, io_type);
    cops->destroy_compress_ctx(cc);
    + kfree(cc->cpages);
    + cc->cpages = NULL;
    if (!err)
    return 0;
    f2fs_bug_on(F2FS_I_SB(cc->inode), err != -EAGAIN);
    --
    2.25.1


    \
     
     \ /
      Last update: 2020-08-20 14:58    [W:4.166 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site