lkml.org 
[lkml]   [2020]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps
    From
    Date
    Am 20.08.20 um 07:26 schrieb Furquan Shaikh:
    > In `amdgpu_dm_update_backlight_caps()`, there is a local
    > `amdgpu_dm_backlight_caps` object that is filled in by
    > `amdgpu_acpi_get_backlight_caps()`. However, this object is
    > uninitialized before the call and hence the subsequent check for
    > aux_support can fail since it is not initialized by
    > `amdgpu_acpi_get_backlight_caps()` as well. This change initializes
    > this local `amdgpu_dm_backlight_caps` object to 0.
    >
    > Signed-off-by: Furquan Shaikh <furquan@google.com>
    > ---
    > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    > index e4b33c67b634..725d8af634ee 100644
    > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
    > @@ -2853,7 +2853,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
    > static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm)
    > {
    > #if defined(CONFIG_ACPI)
    > - struct amdgpu_dm_backlight_caps caps;
    > + struct amdgpu_dm_backlight_caps caps = { 0 };

    Please use memset instead of "{ 0 }" for initialization.

    Christian.

    >
    > if (dm->backlight_caps.caps_valid)
    > return;

    \
     
     \ /
      Last update: 2020-08-20 09:17    [W:2.546 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site