Messages in this thread | | | Date | Sun, 2 Aug 2020 13:54:22 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v18 3/3] Input: new da7280 haptic driver |
| |
Hi!
> > +static DEVICE_ATTR_RW(ps_seq_id); > > +static DEVICE_ATTR_RW(ps_seq_loop); > > +static DEVICE_ATTR_RW(gpi_seq_id0); > > +static DEVICE_ATTR_RW(gpi_seq_id1); > > +static DEVICE_ATTR_RW(gpi_seq_id2); > > +static DEVICE_ATTR_WO(patterns); > > Should this be a binary attribute instead of having string parsing in > the kernel?
Plus... is this suitable userland interface? Should it be documetned? Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |