Messages in this thread | | | Date | Wed, 19 Aug 2020 15:12:33 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next v2 5/7] net: dsa: mt7530: Add the support of MT7531 switch |
| |
> In general, according to phy.rst, RGMII delay should be done by phy, but > some MoCA product need RGMII delay in MAC. These two requirements > conflict. Is there any suggestion to solve the conflict?
Implementing the delay in the PHY is just a recommendation, not a requirement. However, as i said, you need to be careful what is pass to phylib. If the MAC is implementing "rgmii-id", whatever makes it way down to phy_attach_direct() needs to be "rgmii". If the MAC implements "rgmii-rxid", the phy should be implementing "rgmii-txid", etc. If this is wrong, you get both the MAC and the PHY implementing delays, and bad things happen.
Andrew
| |