Messages in this thread | | | Date | Wed, 19 Aug 2020 15:54:17 +0300 | From | Tony Lindgren <> | Subject | Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management |
| |
* Adam Ford <aford173@gmail.com> [200819 12:21]: > On Tue, Aug 18, 2020 at 11:58 PM Tony Lindgren <tony@atomide.com> wrote: > > > > * Adam Ford <aford173@gmail.com> [200818 15:46]: > > > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > > > return err; > > > } > > > > > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > > > + unsigned long cmd, void *v) > > > +{ > > > + struct ti_bandgap *bgp; > > > + > > > + bgp = container_of(nb, struct ti_bandgap, nb); > > > + > > > + spin_lock(&bgp->lock); > > > + switch (cmd) { > > > + case CPU_CLUSTER_PM_ENTER: > > > + if (bgp->is_suspended) > > > + break; > > > + ti_bandgap_save_ctxt(bgp); > > > + ti_bandgap_power(bgp, false); > > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > > + clk_disable(bgp->fclock); > > > + break; > > > + case CPU_CLUSTER_PM_ENTER_FAILED: > > > + case CPU_CLUSTER_PM_EXIT: > > > + if (bgp->is_suspended) > > > + break; > > > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > > > + clk_enable(bgp->fclock); > > > + ti_bandgap_power(bgp, true); > > > + ti_bandgap_restore_ctxt(bgp); > > > + break; > > > + } > > > + spin_unlock(&bgp->lock); > > > + > > > + return NOTIFY_OK; > > > +} > > > > Hmm to me it looks like is_suspended is not used right now? > > I guess you want to set it in ti_bandgap_suspend() and clear > > it in ti_bandgap_resume()? > > > > Otherwise looks good to me, I can't test the power consumption > > right now though so you may want to check it to make sure > > device still hits off mode during idle. > > I have a V2. Do you want me to re-post 2/2 with V2 as no change, or > should I just submit this patch alone?
Up to you, might make it easier for other folks to follow if the whole series is reposted.
Regards,
Tony
| |